meven added a comment.
In D27539#615288 <https://phabricator.kde.org/D27539#615288>, @dfaure wrote: > kfileitemtest still passes? It does, and I added more tests. A question I have is that in case we don't find an icon depending on how we determine it we can return `application-octet-stream` or `unknown`. I guess we should return one of the two, in all cases. I would be in favor of `unknown` as application may be already checking this value. That would mean `if (mt.iconName() == "application-octet-stream") return "unknown"`. REPOSITORY R241 KIO BRANCH arcpatch-D27539 REVISION DETAIL https://phabricator.kde.org/D27539 To: meven, ngraham, #frameworks, dfaure, broulik, sitter Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
