cgiboudeaux added inline comments.

INLINE COMMENTS

> kconfigbackend_p.h:6
> +
> +    Portions:
> +    SPDX-FileCopyrightText: 1997 Matthias Kalle Dalheimer <ka...@kde.org>

I don't think this is useful

> kconfigini_p.h:6
>  
> -   This library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Library General Public
> -   License as published by the Free Software Foundation; either
> -   version 2 of the License, or (at your option) any later version.
> +   Portions:
> +   SPDX-FileCopyrightText: 1997 Matthias Kalle Dalheimer <ka...@kde.org>

same thing here

> kcfg.xsd:20
> +
> +            SPDX-License-Identifier: BSD-2-Clause
>  

What makes you think it's BSD?

> kwriteconfig.cpp:6-7
>  
> -    Programmed by Luís Pedro Coelho <luis_pe...@netcabo.pt>
> -    based on kreadconfig by Bernhard Rosenkraenzer <b...@redhat.com>
> +    SPDX-FileContributor: Programmed by Luís Pedro Coelho 
> <luis_pe...@netcabo.pt>
> +    SPDX-FileContributor: based on kreadconfig by Bernhard Rosenkraenzer 
> <b...@redhat.com>
>  

These 2 lines are only explanations about the 2 copyright holders listed above. 
They shouldn't be modified

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27601

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Reply via email to