meven added inline comments. INLINE COMMENTS
> test_properties_minmax.h.ref:43 > + Q_PROPERTY(int bar READ bar WRITE setBar NOTIFY barChanged) > + Q_PROPERTY(bool isBarImmutable CONSTANT) > + /** This is incorrrect since D27496 <https://phabricator.kde.org/D27496>, too bad this was not rebased and tested before before landing It causes test failures : WARNING: KConfigCompiler_Test::testRunning(test_properties_minmax) testdata test_properties_minmax could not be located! Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(155)] FAIL! : KConfigCompiler_Test::testRunning(test_properties_minmax) '!program.isEmpty()' returned FALSE. (test_properties_minmax must exist!) Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(156)] WARNING: KConfigCompiler_Test::testRunning(test_param_minmax) testdata test_param_minmax could not be located! Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(155)] FAIL! : KConfigCompiler_Test::testRunning(test_param_minmax) '!program.isEmpty()' returned FALSE. (test_param_minmax must exist!) Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(156)] FAIL! : KConfigCompiler_Test::testBaselineComparison(test_properties_minmax.h) 'false' returned FALSE. (This test failed, look at the following file for details: /repositories/src/kconfig/autotests/kconfig_compiler/test_properties_minmax.h.ref.diff) Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(190)] FAIL! : KConfigCompiler_Test::testBaselineComparison(test_properties_minmax.h) 'content == contentRef' returned FALSE. () Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(135)] REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27497 To: hchain, meven, crossi, ervin, bport, tcanabrava Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
