thiago added a comment.
Still want to see that round-trip. INLINE COMMENTS > smburltest.cpp:112 > + // % character - run through .url() to simulate behavior of our > listDir() > + > QCOMPARE(SMBUrl(QUrl(QUrl("smb://?kio-workgroup=HAX%MAX").url())).toSmbcUrl(), > + "smb://HAX%25MAX/"); Please don't use QUrl's URL-correction in the constructor. This is not a valid URL. Use %25 here. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27804 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, thiago, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov