ervin added inline comments. INLINE COMMENTS
> meven wrote in kcoreconfigskeleton.cpp:580 > You mean I should prepare this and put it in KF6 waiting for merge queue ? No I meant the comment needs to be adjusted due to the changes (fields changing place and such) sorry if I was unclear. > meven wrote in kcoreconfigskeleton.h:788 > I have one in `QString KCoreConfigSkeleton::ItemEnum::valueForChoice(QString > name) const` Yeah, noticed only later... I wonder if it's more obvious in the header or the cpp... REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns