kossebau added inline comments. INLINE COMMENTS
> dfaure wrote in kfilefiltercombo.cpp:31 > Err why don't you include kiofilewidgets_debug.h instead? > > You're redefining what the generated file contains, here. No, the generated one contains only `kf5.kio.filewidgets`, not `kf5.kio.filewidgets.kfilefiltercombo`. That's why I proposed to invert things and use `ecm_qt_declare_logging_category()` for the latter, so we have a generated header to include indeed for the caegory we use here, and use `ecm_qt_export_logging_category()` for the virtual base category `kf5.kio.filewidgets` instead (done only to have this one available & "documented" in KDebugSettings). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27865 To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
