crossi planned changes to this revision. crossi added inline comments. INLINE COMMENTS
> ervin wrote in test_subgroups.kcfg:10 > Now that I see it, I think I'd go for "parentGroupName" since this is not > referential and really about the name (like the name parameter) `parentGroupName` sounds more explicit, I will replace with it. > ervin wrote in KConfigSourceGenerator.cpp:354 > Unrelated right, this is not due to your patch, or am I confused? It was there before my patch, just pointing it for later. Fortunately, some of the concerns have been addressed in D27497 <https://phabricator.kde.org/D27497> REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
