davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
This is rather horrible, but at the same time makes a lot of sense.
One minor comment, but then, ship it I guess.
INLINE COMMENTS
> DBusHelperProxy.cpp:273
> + QMetaMethod method;
> + for (int i = metaObj->methodOffset(); i <= metaObj->methodCount();
> ++i) {
> + if (QLatin1String(metaObj->method(i).name()) != slotname) {
we could:
int offset = metaObj->indexOfMethod(slotname);
instead of a loop.
REPOSITORY
R283 KAuth
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26969
To: sitter, apol, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
