sitter added a comment.
Unit test? (: I also wonder if maybe this should be lazy allocated. The vast majority of applications probably will never set it, so allocating the memory on first use should be better for the great majority of applications while making no difference for the gdb side of crash reporting. INLINE COMMENTS > kcrash.cpp:993 > > +void KCrash::setErrorMessage(const QString& message) > +{ & on the wrong side of the space REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns