ngraham added inline comments. INLINE COMMENTS
> ngraham wrote in kpropertiesdialog.cpp:645 > /home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:645:18: error: > ‘class KService’ has no member named ‘serviceId’ > > `QStringLiteral` Build failure from this issue is not resolved yet > kpropertiesdialog.h:251 > + */ > + void KPropertiesDialog::insertPluginAt(KPropertiesDialogPlugin *plugin, > int index); > + Remove `KPropertiesDialog::` from this function definition REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
