dfaure added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kdirmodeltest_gui.cpp:92
> I did test the /usr/share/fonts path :); it's just that starting at "/" 
> looked "normal", whereas starting at a specific dir conveyed the goal of this 
> change better, to me anyway.

It doesn't look "normal" : without the ShowRoot feature, you wouldn't see the 
"/" root node.
So I would say the test program is valid, no matter what the starting directory 
is.

(I was wrong about passing a path as argument, this goes into the code path 
that does NOT set ShowRoot)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Reply via email to