dfaure added a comment.
Thanks, looks better. One possible problem left: if KIO has never been
installed, I guess
QStandardPaths::findExecutable(QStringLiteral("ktelnetservice5")) won't find it
in builddir/bin.
You could push and see what CI says, or you could test locally what happens
when running this test method with PATH=/does/not/exist.
It seems to me that desktopexecparser.cpp won't find it then, which should
probably be fixed with a fallback to "if it exists in
QCoreApplication::applicationDirPath(), use that" -- and then the unittest can
do the same.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27999
To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
