bruns added inline comments.
INLINE COMMENTS
> taglibwriter.cpp:78
>
> +TagLib::String determineMimeTypeOfPicture(const QByteArray &pictureData)
> +{
https://doc.qt.io/qt-5/qmimedatabase.html#mimeTypeForData
> taglibwriter.cpp:85
> + pictureData.startsWith(QByteArray::fromHex("FFD8FFEE")) ||
> + pictureData.startsWith(QByteArray::fromHex("FFD8FFE1"))) {
> + return TagLib::String("image/jpeg");
This list is incomplete - there are also plain jpegs which start with a
huffmann table, and Adobe apparent writes ones which start with an FFEE
application marker.
REPOSITORY
R286 KFileMetaData
BRANCH
tagLibBinaryWrite
REVISION DETAIL
https://phabricator.kde.org/D25679
To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
