dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
I would prefer a unittest based on public API, showing the actual bug (before the fix) with kdeglobals and a local config file. INLINE COMMENTS > kconfigdata.h:76 > + /** > + * Entry will need to be wrote on a not global file even if it match > default value > + */ s/wrote/written/ s/match/matches/ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28128 To: bport, ervin, dfaure, meven, crossi, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns