kossebau added inline comments.
INLINE COMMENTS
> global.h:320
> + */
> +enum StatDetail {
> + /// No field returned, useful to check if a file exists
This injects generic terms like `Basic`, `User`, `Time`, `Acl`, etc. into the
KIO namespace, with no futher hint that these belong to this very enum,
resulting in potential wrong usages (due to completion-based coding when being
convertable to int) or in potential conflicts with other future additions.
Sadly no time to follow the review. Had this been discussed before? Ideally
those flags would get more explicit names, like `BasicDetail` (hm, what is
basic actually), `UserDetail`, etc.
Could not find naming recommendations for current Qt, but here some old one,
scroll to the section "Naming Enum Types and Values":
https://doc.qt.io/archives/qq/qq13-apis.html#theartofnaming
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25010
To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
ngraham, bruns
