leinir marked 5 inline comments as done. leinir added inline comments. INLINE COMMENTS
> broulik wrote in EntryScreenshots.qml:133 > Not needed given you `anchors.fill` Ah yes, quite :) > broulik wrote in EntryScreenshots.qml:135 > What's this for? That's a good question, really - i found that in the KCM GridDelegate and just sort of left it in... but yup, probably not needed :) > broulik wrote in TileDelegate.qml:123 > `shadow.size` corresponds to the old `radius`, so you'd want to set > `Kirigami.Units.largeSpacing` here Less magic numbers are a nice thing ;) > broulik wrote in TileDelegate.qml:124 > `#80` used in the old code is 128, i.e. `0.5` alpha, unless you want to make > it look consistently with the shadows used elsewhere? Yeah, that was for consistency, but well spotted :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
