davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision.
REVISION SUMMARY KProcessRunner had two code paths for if data was part of the KService or if it was separate pars. This leads to a lot of args and extra if statements. We can move this abstraction into CommandLineJob, creating a KService instance as a data structure for our explicitly set iconName and user visible name and command line. TEST PLAN Relevant unit test REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28278 AFFECTED FILES src/gui/commandlauncherjob.cpp src/gui/kprocessrunner.cpp src/gui/kprocessrunner_p.h To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
