zzag added inline comments.

INLINE COMMENTS

> inputmethod_interface.cpp:128
> +    {
> +        wl_resource_destroy(resource->handle);
> +        if (resourceMap().isEmpty())

Don't call wl_resource_destroy() in foobar_destroy_resource(), it's dangerous.

  void zwp_input_method_context_v1_destroy(Resource *resource)
  {
      wl_resource_destroy(resource->handle);
  }
  
  void zwp_input_method_context_v1_destroy_resource(Resource *resource)
  {
      Q_UNUSED(resource)
      q->deleteLater();
  }

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27338

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

Reply via email to