kossebau added a comment.
Just as reminder:
When keeping the use of the macro flags, make sure to
- also set the `*_DEPRECATED_WARNINGS_SINCE` flags to 0x060000, otherwise
deprecation warnings for newer API will no longer be shown, due to default set
by `*_DISABLE_DEPRECATED_BEFORE*`
- remove the `if (EXISTS "${CMAKE_SOURCE_DIR}/.git")` wrapper, to ensure
released builds see the same API as developer builds (chance of running
otherwise into method overloads/implicit conversions)
This would be the recommended use to control limit of deprecated API not
visible to compiler and limit of until which version use of deprecated API will
be warned about:
add_definitions(
# hide deprecated API of Qt <= 5.9
-DQT_DISABLE_DEPRECATED_BEFORE=0x050900
# enable warnings for API up to Qt 6.0
-DQT_DEPRECATED_WARNINGS_SINCE=0x060000
# hide deprecated API of KF <= 5.48
-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053000
# enable warnings for API up to KF 6.0
-DKF_DEPRECATED_WARNINGS_SINCE=0x060000
)
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D25660
To: nicolasfella, #frameworks, dfaure
Cc: mlaurent, bcooksley, kossebau, dfaure, apol, kde-frameworks-devel,
LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
