niccolove added inline comments.

INLINE COMMENTS

> metadata.desktop.cmake:99
> -contrast=0.2
> -#intensity is disabled, in order to auto adjust to the chosen theme color
> -#intensity=2.0

I changed this because: simply put, it doesn't work. I opened a bug about it 
https://bugs.kde.org/show_bug.cgi?id=416699. It results in weird colors that 
have nothing to do with the background. If I understood it correctly, it's 
supposed to tweak the value based on the background darkness in order to make 
the background more light in those cases and preserving readability, but that 
does not seem to work either as there are some places in the 'before' 
screenshots that look way too dark, and are instead much more readable with 
this patch.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Reply via email to