niccolove marked an inline comment as done.
niccolove added inline comments.

INLINE COMMENTS

> davidedmundson wrote in PlasmoidHeading.qml:77
> What should happen if this is set to merged and someone uses a theme that 
> doesn't have a merged- prefix?
> 
> The old SVG or no SVG at all?

I'd go with no SVG, to make sure that the theme creators will see that it's 
broken and add a merged- look. Keep in mind that the plasmoidheading svg was 
added barely one month ago, and no big Plasma release had it yet, so I find it 
very hard to believe that any third party theme already has it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Reply via email to