cochise added inline comments. INLINE COMMENTS
> dfaure wrote in file_unix.cpp:184 > You're doing two copies here. From `offset` to `key.data()`, and then from > `key.data()` -- the return value of qstrcpy -- into the QByteArray key (which > calls the QByteArray(const char*) constructor). > > This can be simplified. > Option 1: just remove the assignment, just do the qstrcpy. But it still > smells like C to me. And there's a security bug if keyLen is ever too small. > Option 2: QByteArray key(offset); So simple. No need for strlen before, no > need for qstrcpy, it all happens internally in that constructor. So many time looking for a way to get a copy until a null, and it's in one of the constructors. This looks a lot better. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh
