dfaure added inline comments.

INLINE COMMENTS

> broulik wrote in applicationlauncherjob.h:50
> Please add this in a separate commit

Done in https://commits.kde.org/kio/01a4b70803d5bc9144a7ca7aec12081b4356c638
(also in CommandLauncherJob)

> broulik wrote in kpropertiesdialog.cpp:1458
> Call this after setting everything up?

If you want. Makes no difference, the actual start of a KJob is always delayed.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28266

To: dfaure, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Reply via email to