bport added a comment.
> !hasDefault() checks [system config files] and therefore should stay. Otherwise, when the situation is C++=1 system=2 and value to be written is 1 you'll revert() i.e. not write anything and then re-read 2, oops. > Sounds like you should add a unittest for this case, to detect this regression... I added an unittest to be sure I test the regression (let me know if I don't test what you had in mind). However no code changes are needed because in this case mReference and mDefault are different (mDefault will be equal to the value from system file) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28221 To: bport, ervin, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
