zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > buffer_interface.cpp:287-291 > size.width(), > size.height(), > wl_shm_buffer_get_stride(shmBuffer), > imageFormat, > + &imageBufferCleanupHandler, this); Please re-indent this code. > xdgforeigntest.cpp:133 > auto parentDeco = m_decoration->create(m_surface, this); > + Q_UNUSED(parentDeco); > m_shellSurface = m_shell->createSurface(m_surface, this); You don't need to put a semicolon after the Q_UNUSED macro. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28442 To: apol, #frameworks, #kwin, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
