ndavis added inline comments.

INLINE COMMENTS

> davidhurka wrote in filename-title-amarok.svg:8
> I realized that http://notmart.org/blog/2016/05/icon-colors/ and 
> https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets
>  contratict in the class names. One uses `ColorScheme-Highlight`, the other 
> `ColorScheme-ButtonFocus`. breeze-icon-cleaner uses 
> `ColorScheme-ButtonFocus`. In the repository I see several icons which use 
> `ColorScheme-Highlight`, and only a few which use `ColorScheme-ButtonFocus`.
> 
> So which one is correct? I assume that 
> https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets
>  needs to be fixed.

Yeah, I'd rather use ButtonFocus, but it actually doesn't work outside of 
plasmashell, so use Highlight instead

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

Reply via email to