apol added a comment.
+1 Makes sense, the code looks a bit fiddly but should allow cleaner code. INLINE COMMENTS > kossebau wrote in udsentry.h:127 > Do you mean deep-copy by memcopy? There should be no such, the > `UDSEntryInitListEntry(uint field, const QString &value)` constructor does a > normal shared copy: > > new(m_u.s) QString(value); > > At least by what I understand and the test/experiments told me. > > Still chances I missed something, being the first time I do such code, so > tear apart where needed :) Yeah you're right. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28528 To: kossebau, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
