dvratil added inline comments. INLINE COMMENTS
> calendarentry.cpp:36 > + > +CalendarEntry::~CalendarEntry() > +{ ` = default` (instead of empty body) > calendarentry.cpp:57 > +{ > + return ReadWrite; > +} Should that be `d->type`? How can implementations change it? Will implementation have to access `calendarentry_p.h`? REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss