bruns added a comment.
looks good to me otherwise
INLINE COMMENTS
> jobtest.cpp:1537
> +
> + // this test doesn't make sense on the CI as it's an LXC container with
> one partition
> + if (otherTmpDirIsOnSamePartition()) {
slight rewording
// In case the two tmp dirs are on the same partition (e.g. on the CI), the
// device IDs should match, otherwise they should be different
and then
} else {
QCOMPARE(device, otherDevice);
}
> ahmadsamir wrote in jobtest.cpp:1510
> OK, that makes sense. Done.
nitpick - the test name now again is wrong ;-)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28478
To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
