dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
This, hmm, sounds wrong. Is the caller calling pid() even though the job finished with an error code? Ah, yes, indeed, in the case of KRun. Whoops. Here's my suggested fix instead: D28598 <https://phabricator.kde.org/D28598> REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28592 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
