apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
LGTM
INLINE COMMENTS
> configview.cpp:137
>
> +
> q->engine()->rootContext()->setContextProperty(QStringLiteral("plasmoid"),
> applet.data()->property("_plasma_graphicObject").value<QObject *>());
> +
> q->engine()->rootContext()->setContextProperty(QStringLiteral("configDialog"),
> q);
It could make sense to use the opportunity to change to
QQmlContext::setContextProperties.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28599
To: davidedmundson, #plasma, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
