meven added a comment.
In D27951#641207 <https://phabricator.kde.org/D27951#641207>, @trmdi wrote: > In D27951#641173 <https://phabricator.kde.org/D27951#641173>, @meven wrote: > > > In D27951#639386 <https://phabricator.kde.org/D27951#639386>, @trmdi wrote: > > > > > In D27951#639350 <https://phabricator.kde.org/D27951#639350>, @meven wrote: > > > > > > > Anything that concerns a kdeconnet:/ url is handled by the kdeconnect ioslave, including the stat call made in `KIO::StatJob`. > > > > It is in the kdeconnect code base, the issue you point to is there. > > > > > > > > > Thanks, got it. Then could we simply use KMountPoint instead of UDS_Device_ID ? KMountPoint seems more reliable. > > > > > > But KMountPoint induces more cost (it makes a syscall and a bunch of parsing). > > So instead I would recommend fixing the issue in kdeconnect (and potentially other ioslave) as it will fix things here and elsewhere potentially too. > > > > Also `local = url.isLocalFile` should return false for kdeconnect in the first place. > > So I belive you can avoid using KMountPoint at all and use only stat. > > > No, kde connect files have local urls. I thought their file scheme would be kdeconnect. They would be on a fuse mount, either way it is detectable. > Fixing every ioslave is too difficult. > So I should drop this idea. It does not rest on your shoulder only, fear not. I did not expect you to do all of this, but this could be a very shorltist as we don't that many writable filesystem-like ioslave that will need actual fixing. I meant this is not your concern for this patch. This is a nice feature some of our users will appreciate. So I would encourage you to reconsider abandoning this work. I might take over to finish it eventually. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson Cc: bruns, elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham