dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > kpropertiesdialog.cpp:1285 > + // exclude remote dirs as changing the icon has no effect (bug > 205954) > + if (item.isLocalFile()|| item.url().scheme() == > QLatin1String("desktop")) { > + return true; missing space before || REPOSITORY R241 KIO BRANCH l-kprop (branched from master) REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns