sandsmark added inline comments. INLINE COMMENTS
> broulik wrote in currency.cpp:57 > Can probably just use `QNetworkConfigurationManager::isOnline()`? IIRC that's less reliable (e. g. if you don't use networkmanager or connman). the whole bearer thing is a bit messy, I guess that's why it's going away. but this is also not very good, it just checks for IPs while it should at the very least wait for a route to a gateway (I spent way to much time on this problem at work...). tldr: we could probably just remove the whole thing, that's why I added the retry-timer. > broulik wrote in currency.cpp:154 > Whenever you do networking in KDE, ensure it follows redirects: > `setRedirectPolicy(QNetworkRequest::NoLessSafeRedirectPolicy)` I guess I don't think that makes sense, but sure. > ngraham wrote in currency.cpp:884 > why? Because: F8233868: image.png <https://phabricator.kde.org/F8233868> REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28770 To: sandsmark, ngraham, #frameworks, broulik Cc: broulik, ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, michaelh, bruns
