vkrause added a comment.
In D28834#648405 <https://phabricator.kde.org/D28834#648405>, @winterz wrote: > I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now This is handled automatically, no need to change this. INLINE COMMENTS > calendar.h:101 > +*/ > +enum CalendarType > +{ As already noted in the previous review, "type" isn't the best naming for something that is about access control/permission IMHO. A possible alternative name could be something like "AccessMode", or maybe even just bool isReadOnly. REPOSITORY R172 KCalendar Core BRANCH props REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, mlaurent, knauss, dvratil
