romangg added inline comments.

INLINE COMMENTS

> screencast.xml:8
> +  ]]></copyright>
> +    <interface name="org_kde_kwin_screencast" version="1">
> +        <description summary="Protocol for managing Pipewire feeds of the 
> different displays and windows."/>

Interface names should be scoped too. Example 
<https://gitlab.freedesktop.org/wayland/wayland-protocols/blob/master/unstable/linux-explicit-synchronization/linux-explicit-synchronization-unstable-v1.xml#L29>.

Don't ask me why exactly why. I think it has something to do with the C structs 
becoming ambiguous otherwise. Someone else knows?

But in any case I would follow the examples set by upstream.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

Reply via email to