broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson, kossebau, kfunk, habacker.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It serves as a replacement for `kdbusaddons_generate_dbus_service_file`.
  
  An application can be a DBus-activated service just fine without using 
KDBusAddons.
  Moreover, this new module uses named arguments for future-proofing, and adds 
support for specifying a `SystemdService`.
  It also cleans up the confusion on what the "path" is about: Rather than 
requiring to specify executable and path separately, we just extract the 
executable file name on Windows, if necessary.

TEST PLAN
  - Was able to generate a kded service file
  - Was able to generate a kded service file with `SystemdUnit`
  - Verified that it moaned when executable wasn't an absolute path
  - Untested on Windwos

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29051

AFFECTED FILES
  modules/ECMGenerateDBusServiceFile.cmake

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

Reply via email to