alex added inline comments. INLINE COMMENTS
> leinir wrote in installation.cpp:632 > This will want to be more... question like... "The thing failed" isn't really > a question, not sure how the user's supposed to make an informed choice based > on that... Perhaps something like "The uninstallation process failed to run > the command %1. The output was:\n%2\nIf you think this is incorrect, you can > continue, or you can cancel the process." (given how much this is an error > situation, it feels like we can give the user a bit of technical > information... cancelling in a panic would be the appropriate reaction to "I > don't know" anyway for this sort of thing, so thinking we'd be ok with doing > that). Yes I get what you mean :-). I was just not sure where this patch should land (I asked about this in a previous comment) and wanted to know this before editing translations. But I guess it will go on master then? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
