bruns added a comment.
In D28590#656133 <https://phabricator.kde.org/D28590#656133>, @meven wrote: > In D28590#654139 <https://phabricator.kde.org/D28590#654139>, @bruns wrote: > > > Do not create m_storageAccess in the constructor > > > Hmm, you told me `the f (m_displayName.isEmpty()) block belongs here`, I don't see why instantiating `m_storageAccess` here is bad but mehh. Please read again. 1. m_storageAccess is comparatively expensive 2. I showed you how to get the mount state without StorageAccess 3. I told you where to initialize it, yes. Doing it correctly of course still applies. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
