dfaure added inline comments. INLINE COMMENTS
> CMakeLists.txt:60 > > -add_definitions(-DQT_NO_URL_CAST_FROM_STRING) > +add_definitions(-DQT_NO_URL_CAST_FROM_STRING -DQT_NO_CAST_TO_ASCII) > Isn't that what I did here? Now all of kio-extras gets that flag. And BTW everything built by kdesrc-build actually builds with this flag (since I have it in my kdesrc-buildrc). But that doesn't allow setting it in ECM, there is more code using ECM out there... REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D29149 To: dfaure, thiago, sitter Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov