svuorela accepted this revision. svuorela added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > kcmoduleinfo.cpp:73 > + lib = pluginInfo.libraryPath(); > + keywords = > pluginInfo.property(QStringLiteral("Keywords")).toStringList(); > } At a later point, I*m not sure what the purpose is for these members are - but that's probably for another changeset. > kcmoduleinfo.h:131 > + * @warning This will be null if this KCModuleInfo was created from a > KPluginInfo coming from KPluginMetaData. > + * Prefer using pluginInfo() instead, which works for both kinds. > + */ Can we mark it as deprecated? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela Cc: svuorela, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns