elvisangelaccio accepted this revision. elvisangelaccio added a subscriber: iasensio. elvisangelaccio added a comment. This revision is now accepted and ready to land.
LGTM but I'd like input from @iasensio too. INLINE COMMENTS > dolphinsearchbox.h:164 > private: > + QString getQueryTitle(const QString& text) const; > + Please drop the `get` prefix. REPOSITORY R318 Dolphin BRANCH arcpatch-D29198 REVISION DETAIL https://phabricator.kde.org/D29198 To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks Cc: iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
