----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/#review49074 -----------------------------------------------------------
Ship it! Fixes the signbit issue also on Mac OS X :) - Harald Fernengel On Feb. 5, 2014, 5:03 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115502/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 5:03 p.m.) > > > Review request for KDE Frameworks, Bernd Buschinski and Harald Fernengel. > > > Repository: kjs > > > Description > ------- > > Fix math function checks > > Between things being in the std:: namespace and <math.h> and <cmath> > interfering with each other (at least for glibc), the configure checks > for math functions do not actually perform the checks they claim to. > > This tests that the functions (in whatever form) can reasonably be > called from C++ code that includes both <math.h> and <cmath>. > > > Diffs > ----- > > src/kjs/ConfigureChecks.cmake 473da1c19c9e8788e3ac407d382f8bcf4882a10f > src/kjs/global.h.cmake d821a7264f0e2b46b422a8d68d397799a288bde9 > src/kjs/operations.h a54f366330b937a027d478cbe018a7c1c21c1625 > > Diff: https://git.reviewboard.kde.org/r/115502/diff/ > > > Testing > ------- > > Configures, builds and installs with gcc 4.8.2 and glibc 2.18 (Archlinux). > The configure checks report the results you would expect (providing you are > aware that cmath undefs signbit). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel