crossi added a comment.
some code style related comments INLINE COMMENTS > test_keyboard_shortcuts_inhibitor_interface.cpp:109 > + m_manager = m_display.createKeyboardShortcutsInhibitManager(this); > + QVERIFY(m_serverCompositor->isValid()); > + connect(m_serverCompositor, &CompositorInterface::surfaceCreated, this, > [this](SurfaceInterface *surface) { indentation > test_keyboard_shortcuts_inhibitor_interface.cpp:154 > + for (int i = 0; i < 3; ++i) { > + KWayland::Client::Surface *s > =m_clientCompositor->createSurface(this); > + m_clientSurfaces += s->operator wl_surface *(); add space after = > display.h:328 > + */ > + KeyboardShortcutsInhibitManagerInterface > *createKeyboardShortcutsInhibitManager(QObject *object); > + parameter should be `QObject *parent = nullptr` > keyboard_shortcuts_inhibit_interface.h:69 > + friend class KeyboardShortcutsInhibitorInterface; > + explicit KeyboardShortcutsInhibitManagerInterface(Display *d, QObject > *parent); > + void removeInhibitor(SurfaceInterface *const surface, SeatInterface > *const seat); parent parameter should be defaulted to nullptr REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29231 To: bport, zzag, davidedmundson, apol Cc: romangg, crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns