cblack added inline comments.
INLINE COMMENTS
> KeySequenceItem.qml:57
> + ToolTip.visible: hovered
> + ToolTip.delay: 1000
> + ToolTip.text: _tr.i18n("Click on the button, then enter the
> shortcut like you would in the program.\nExample for Ctrl+A: hold the Ctrl
> key and press A.")
Are we able to use some form of units? Hardcoding this seems wrong.
> KeySequenceItem.qml:59
> + ToolTip.text: _tr.i18n("Click on the button, then enter the
> shortcut like you would in the program.\nExample for Ctrl+A: hold the Ctrl
> key and press A.")
> + ToolTip.timeout: 5000
>
Ditto here, but even hardcoded this looks wrong.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D29292
To: davidedmundson, #plasma
Cc: cblack, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
