kossebau added a comment.
In D29136#660358 <https://phabricator.kde.org/D29136#660358>, @heikobecker wrote: > > Where would you see "that the macro already used KDEInstallDirs before"? When it comes to "LOCALE_INSTALL_DIR", that is set to a default is not set when calling the macro. Ideally would be documented though. (my first approach would be to also allow a soft dependency here on KDEInstallDirs, checking whether KDE_INSTALL_LOCALEDIR is defined and picking its value), similar with CMAKE_INSTALL_LOCALEDIR to support GnuInstallDirs automatically). > > As you indicate, if one calls ki18_install() in a project which includes KDEInstallDirs before that call (and KDE_INSTALL_DIRS_NO_DEPRECATED isn't set) the value of LOCALE_INSTALL_DIR is used instead of the default "share/locale". I extended the same to check K_I_LOCALEDIR (line 99+). Isn't that the soft dependency you suggested (minus the GnuInstallDirs part, obviously?) I was more thinking something along D29299 <https://phabricator.kde.org/D29299> (turned my draft code into a proper patch for discussing, while at it :) ). From what I meanwhile found, people using GnuInstallDirs would only have CMAKE_INSTALL_LOCALEDIR set, so they can be ignored here then, at least I would rather advocate for explicite argument passing as in the alternative patch. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29136 To: heikobecker Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
