ahmadsamir marked an inline comment as done. ahmadsamir added inline comments.
INLINE COMMENTS > pino wrote in renamedialog.cpp:299 > this is not right-to-left aware; please use the layout direction of the > widget to use "go-next" or "go-previous" @pino, right; dolphin isn't rtl-aware (or if it is, I couldn't find out how to switch it to rtl). But I agree the code here should account for rtl anyway. @ngraham: I think we should stick to the icon naming spec[1], so that it works with themes other than breeze/oxygen; so it has to be go-previous. [1] https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html REPOSITORY R241 KIO BRANCH l-srt-to-dest (branched from master) REVISION DETAIL https://phabricator.kde.org/D29254 To: ahmadsamir, #frameworks, dfaure, meven, ngraham Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
