aacid added inline comments.

INLINE COMMENTS

> kiconloader.cpp:1142
> +        for (const QString &path : fallbackPaths) {
> +            const QStringList extensions = QStringList() << 
> QStringLiteral(".png") << QStringLiteral(".svg") << QStringLiteral(".svgz") 
> << QStringLiteral(".xpm");
> +

Would it make sense trying to use QIconLoader::lookupFallbackIcon ? This way we 
"upstream" Qt behaviour? For example you're supporting svgz while Qt doesn't. 
Which would mean different QIcon::fallbackSearchPaths whether you're using 
KIconLoader or not which doesn't seem totally great?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29390

To: nicolasfella, #plasma, #frameworks
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Reply via email to