nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision.
REVISION SUMMARY In KNotificationManager when reading the actions default to Popup when no actions are found. In notifybypopup default to QGuiApplication::applicationDisplayName() when reading the app name. The logic for the icon is not changed, worst case we get empty which may get overridden by the user. Other backends are still todo TEST PLAN Deleted notifyrc file from KDE Connect. Still get notifications. As a side effect the pairing notification now shows "KDE Connect Daemon" instead of "KDE Connect". This could be changed with a new setter or x-kde-display-appname REPOSITORY R289 KNotifications BRANCH nonotifyrc REVISION DETAIL https://phabricator.kde.org/D29405 AFFECTED FILES src/knotificationmanager.cpp src/notifybypopup.cpp To: nicolasfella, #frameworks, broulik, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
