leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision.
REVISION SUMMARY This patch primarily fixes the issue that when picking the "Updateable Only" option on NewStuff.Page, we would be shown all the entries anyway. It also fixes duplicated entries on the "Installed Only" option, and further adds a little placeholder for when the view is expectedly empty. - Use the right connections for update entry display - While potentially expensive, only add entries to the model once - Use Kirigami.PlaceholderMessage to show we have no entries when we don't BUG:416762 TEST PLAN Without this patch, behaviour is as shown in https://bugs.kde.org/show_bug.cgi?id=416762 With this patch, the behaviour is as expected (shows only updateable entries with that option selected, only shows installed entries once with that option, and shows a useful message when the list is empty and expected to be empty) REPOSITORY R304 KNewStuff BRANCH fix-show-only-updates (branched from master) REVISION DETAIL https://phabricator.kde.org/D29447 AFFECTED FILES src/core/itemsmodel.cpp src/qtquick/qml/Page.qml src/qtquick/quickitemsmodel.cpp To: leinir Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
